Re: [PATCH] mingw: make stderr unbuffered again

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 14, 2017, 14:47 UTC
Message-ID: <alpine.DEB.2.20.1702141545380.3496@virtualbox>
In-Reply-To: <xmqqlgt9btrv.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 13 Feb 2017, Junio C Hamano wrote:

Show 21 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > When removing the hack for isatty(), we actually removed more than just
> > an isatty() hack: we removed the hack where internal data structures of
> > the MSVC runtime are modified in order to redirect stdout/stderr.
> >
> > Instead of using that hack (that does not work with newer versions of
> > the runtime, anyway), we replaced it by reopening the respective file
> > descriptors.
> >
> > What we forgot was to mark stderr as unbuffered again.
> >
> > Reported by Hannes Sixt. Fixed with Jeff Hostetler's assistance.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > Published-As: https://github.com/dscho/git/releases/tag/mingw-unbuffered-stderr-v1
> > Fetch-It-Via: git fetch https://github.com/dscho/git mingw-unbuffered-stderr-v1
> 
> OK.  Should this go directly to 'master', as the isatty thing is
> already in?

From my point of view, it is not crucial. The next Git for Windows version will have it, of course, and Hannes is always running with his set of patches, he can easily cherry-pick this one, too.

Ciao, Johannes

P.S.: Could you please cut the remainder of the mail that you are not responding to? Thanks.