Re: [PATCH] mingw: make stderr unbuffered again

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 14, 2017, 18:45 UTC
Message-ID: <ef8549ea-7222-fdd0-739d-855ad428e39c@kdbg.org>
In-Reply-To: <alpine.DEB.2.20.1702141545380.3496@virtualbox>

Am 14.02.2017 um 15:47 schrieb Johannes Schindelin:

Show 11 quoted lines

> On Mon, 13 Feb 2017, Junio C Hamano wrote:
>> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>>> When removing the hack for isatty(), we actually removed more than just
>>> an isatty() hack: we removed the hack where internal data structures of
>>> the MSVC runtime are modified in order to redirect stdout/stderr.
>>>
>>> Instead of using that hack (that does not work with newer versions of
>>> the runtime, anyway), we replaced it by reopening the respective file
>>> descriptors.
>>>
>>> What we forgot was to mark stderr as unbuffered again.

I do not see how the earlier patch turned stderr from unbuffered to buffered, as it did not add or remove any setvbuf() call. Can you explain?

Show 6 quoted lines

>> OK.  Should this go directly to 'master', as the isatty thing is
>> already in?
>
>>From my point of view, it is not crucial. The next Git for Windows version
> will have it, of course, and Hannes is always running with his set of
> patches, he can easily cherry-pick this one, too.

The patch fixes the problem for me here.

I am a bit hesitant to call it "not crucial": The symptom I observed is certainly not a show stopper; but who knows where else it is important that stderr goes to the terminal earlier than other output. As it is a new regression, it should be included in the next release.

Thanks, -- Hannes