git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 4/4] convert: add "status=delayed" to filter process protocol

From
Junio C Hamano <gitster@pobox.com>
Date
May 23, 2017, 05:22 UTC
Message-ID
<xmqq1srgm9kq.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<04ECEBE5-CAC8-4344-B07A-6B7A7C795C94@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 13 quoted lines
>>> +	sigchain_pop(SIGPIPE);
>>> +
>>> +	if (err || errno == EPIPE) {
>> 
>> This looks strange, at first glance.
>> Do we set errno to 0 before ?
>> Or is there a trick that EPIPE can only be reached,
>> if it is "our" error ?
>
> You are right and I'll fix it! 
> Thanks for reminding me! 
> Peff also noticed that some time ago:
> http://public-inbox.org/git/20170411200520.oivytvlzkdu7bfh5@sigill.intra.peff.net/

Ben Peart's bp/sub-process-convert-filter topic also had the same EPIPE issues in its earlier incarnation, IIRC. I haven't looked at this topic for some time, but I wonder if we can share code with it.

Previous: Lars SchneiderNext: Lars Schneider
Message 11 of 15 in “convert: add "status=delayed" to filter process protocol”
  1. 0/4 convert: add "status=delayed" to filter process protocolLars Schneider, May 22, 2017
  2. 2/4 t0021: make debug log file name configurableLars Schneider, May 22, 2017
  3. 1/4 t0021: keep filter log files on comparisonLars Schneider, May 22, 2017
  4. 3/4 t0021: write "OUT" only on successLars Schneider, May 22, 2017
  5. 4/4 convert: add "status=delayed" to filter process protocolLars Schneider, May 22, 2017
  6. Taylor BlauMay 22, 2017
  7. Torsten BögershausenMay 22, 2017
  8. Lars SchneiderMay 22, 2017
  9. Torsten BögershausenMay 22, 2017
  10. Lars SchneiderMay 22, 2017
  11. Junio C HamanoMay 23, 2017
  12. Lars SchneiderMay 23, 2017
  13. Lars SchneiderMay 29, 2017
  14. Junio C HamanoMay 30, 2017
  15. Junio C HamanoMay 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.