Re: [PATCH v4 4/4] convert: add "status=delayed" to filter process protocol

> On 23 May 2017, at 10:43, Lars Schneider <larsxschneider@gmail.com> wrote:
> 
> 
>> On 23 May 2017, at 07:22, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Lars Schneider <larsxschneider@gmail.com> writes:
>> 
>>>>> +	sigchain_pop(SIGPIPE);
>>>>> +
>>>>> +	if (err || errno == EPIPE) {
>>>> 
>>>> This looks strange, at first glance.
>>>> Do we set errno to 0 before ?
>>>> Or is there a trick that EPIPE can only be reached,
>>>> if it is "our" error ?
>>> 
>>> You are right and I'll fix it! 
>>> Thanks for reminding me! 
>>> Peff also noticed that some time ago:
>>> http://public-inbox.org/git/20170411200520.oivytvlzkdu7bfh5@sigill.intra.peff.net/
>> 
>> Ben Peart's bp/sub-process-convert-filter topic also had the same
>> EPIPE issues in its earlier incarnation, IIRC.  I haven't looked at
>> this topic for some time, but I wonder if we can share code with it.
> 
> That's right. There might be some code sharing opportunity with Ben's
> code that is already in "next":
> https://github.com/git/git/blob/next/convert.c#L660-L677
> 
> Would it be useful for you if I send v5 with the changes rebased 
> onto "next"?