Re: t3512 & t3513 'unexpected passes'

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2017, 01:40 UTC
Message-ID: <xmqq1skrytsl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171121104404.GN20681@dinwoodie.org>

Adam Dinwoodie <adam@dinwoodie.org> writes:

> I've seen the same unexpected passes, and had just completed the same
> bisect run myself, although I fixed the build failure by cherry-picking
> 82921316a ("SQUASH???", 2017-11-18) onto commits that wouldn't build,
> given that commit seems to exist entirely to fix that build breakage.

Your assumption is correct wrt "SQUASH???". When I am in a hurry and cannot spend extra cycles to pinpoint which one of the commits in a multi-patch series breaks a build, I just fix the breakage on top of the tip commit, and leave it to the original author of the series to apply them down to the original breakage in individual commits when the topic is rerolled.

It seems that the compilation breakage 82921316a fixes comes from its immediate parent, so I'll squash them together, just in case a rerolled topic does not materialize.

Thanks.