t3512 & t3513 'unexpected passes'

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Nov 20, 2017, 20:16 UTC
Message-ID: <73f0fb1e-5b55-1049-7706-652f1f9deaed@ramsayjones.plus.com>

Hi Junio,

For several days, I have been staring at some 'unexpected passes' in the t3512-cherry-pick-submodule.sh and t3513-revert-submodule.sh test files (tests #11-13 in both cases).

I finally found time tonight to 'git bisect' the 'problem', and found
that bisect fingered commit b5a812b298 ("sequencer: try to commit without
 forking 'git commit'", 17-11-2017).

During the bisection I stumbled across (several times) the following compilation error:

      CC sequencer.o
  sequencer.c: In function ‘do_commit’:
  sequencer.c:1142:9: error: void value not ignored as it ought to be
       res = print_commit_summary(NULL, &oid,
           ^
  Makefile:2105: recipe for target 'sequencer.o' failed
  make: *** [sequencer.o] Error 1

which I 'fixed' like so: s/res = //

So, given that the 'fingered' commit didn't immediately seem to be related to the problem, along with the above errors, this may well not be the culprit.

Just FYI.

ATB, Ramsay Jones