Re: t3512 & t3513 'unexpected passes'

From: Adam Dinwoodie <adam@dinwoodie.org>
Date: Nov 21, 2017, 10:44 UTC
Message-ID: <20171121104404.GN20681@dinwoodie.org>
In-Reply-To: <73f0fb1e-5b55-1049-7706-652f1f9deaed@ramsayjones.plus.com>

On Monday 20 November 2017 at 08:16 pm +0000, Ramsay Jones wrote:

Show 24 quoted lines

> For several days, I have been staring at some 'unexpected passes' in
> the t3512-cherry-pick-submodule.sh and t3513-revert-submodule.sh test
> files (tests #11-13 in both cases).
> 
> I finally found time tonight to 'git bisect' the 'problem', and found
> that bisect fingered commit b5a812b298 ("sequencer: try to commit without
>  forking 'git commit'", 17-11-2017).
> 
> During the bisection I stumbled across (several times) the following
> compilation error:
> 
>       CC sequencer.o
>   sequencer.c: In function ‘do_commit’:
>   sequencer.c:1142:9: error: void value not ignored as it ought to be
>        res = print_commit_summary(NULL, &oid,
>            ^
>   Makefile:2105: recipe for target 'sequencer.o' failed
>   make: *** [sequencer.o] Error 1
> 
> which I 'fixed' like so: s/res = //
> 
> So, given that the 'fingered' commit didn't immediately seem to be
> related to the problem, along with the above errors, this may well
> not be the culprit.

I've seen the same unexpected passes, and had just completed the same bisect run myself, although I fixed the build failure by cherry-picking 82921316a ("SQUASH???", 2017-11-18) onto commits that wouldn't build, given that commit seems to exist entirely to fix that build breakage. I think that adds more weight to b5a812b29 being the culprit for these unexpected passes.

It's definitely the case that these unexpected passes exist at 8e4ff0ae1 ("Merge branch 'pw/sequencer-in-process-commit' into pu", 2017-11-21) and do not exist at its immediate left-hand parent, e017a4ccc ("Merge branch 'jn/ssh-wrappers' into jch", 2017-11-21), which means it's clearly _something_ in the branch merged at 8e4ff0ae1.