git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/9] submodule.c: sort changed_submodule_names before searching it

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 26, 2018, 22:14 UTC
Message-ID
<xmqq1s9fkisf.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180925194755.105578-4-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 8 quoted lines
> We can string_list_insert() to maintain sorted-ness of the
> list as we find new items, or we can string_list_append() to
> build an unsorted list and sort it at the end just once.
>
> To pick which one is more appropriate, we notice the fact
> that we discover new items more or less in the already
> sorted order.  That makes "append then sort" more
> appropriate.

I somehow thought that we agreed that the second paragraph above did not make much sense in the previous review round.

    ... goes and looks ...
https://public-inbox.org/git/CAGZ79kbavjVbTqXsmtjW6=jhkq47_p3mc6=92xOp4_mfhqDtvw@mail.gmail.com/
That was two review cycles ago, I guess.
Previous: Stefan BellerNext: Stefan Beller
Message 7 of 14 in “fetch: make sure submodule oids are fetched”
  1. 0/9 fetch: make sure submodule oids are fetchedStefan Beller, Sep 25, 2018
  2. 1/9 sha1-array: provide oid_array_filterStefan Beller, Sep 25, 2018
  3. Junio C HamanoSep 26, 2018
  4. 2/9 submodule.c: fix indentationStefan Beller, Sep 25, 2018
  5. Junio C HamanoSep 26, 2018
  6. 3/9 submodule.c: sort changed_submodule_names before searching itStefan Beller, Sep 25, 2018
  7. Junio C HamanoSep 26, 2018
  8. 4/9 submodule: move global changed_submodule_names into fetch submodule structStefan Beller, Sep 25, 2018
  9. Junio C HamanoSep 26, 2018
  10. 5/9 submodule.c: do not copy around submodule listStefan Beller, Sep 25, 2018
  11. 6/9 repository: repo_submodule_init to take a submodule structStefan Beller, Sep 25, 2018
  12. 7/9 submodule: fetch in submodules git directory instead of in worktreeStefan Beller, Sep 25, 2018
  13. 8/9 fetch: retry fetching submodules if needed objects were not fetchedStefan Beller, Sep 25, 2018
  14. 9/9 builtin/fetch: check for submodule updates for non branch fetchesStefan Beller, Sep 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.