From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 26 Sep 2018 22:14:56 GMT
Subject: Re: [PATCH v4 3/9] submodule.c: sort changed_submodule_names before searching it
Message-ID: <xmqq1s9fkisf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180925194755.105578-4-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> We can string_list_insert() to maintain sorted-ness of the
> list as we find new items, or we can string_list_append() to
> build an unsorted list and sort it at the end just once.
>
> To pick which one is more appropriate, we notice the fact
> that we discover new items more or less in the already
> sorted order.  That makes "append then sort" more
> appropriate.

I somehow thought that we agreed that the second paragraph above did
not make much sense in the previous review round.

    ... goes and looks ...

https://public-inbox.org/git/CAGZ79kbavjVbTqXsmtjW6=jhkq47_p3mc6=92xOp4_mfhqDtvw@mail.gmail.com/

That was two review cycles ago, I guess.