git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 1/9] sha1-array: provide oid_array_filter

From
Stefan Beller <sbeller@google.com>
Date
Sep 25, 2018, 19:47 UTC
Message-ID
<20180925194755.105578-2-sbeller@google.com>
In-Reply-To
<20180925194755.105578-1-sbeller@google.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 Documentation/technical/api-oid-array.txt |  5 +++++
 sha1-array.c                              | 17 +++++++++++++++++
 sha1-array.h                              |  3 +++
 3 files changed, 25 insertions(+)
diff --git a/Documentation/technical/api-oid-array.txt b/Documentation/technical/api-oid-array.txt
index 9febfb1d528..c97428c2c34 100644
--- a/Documentation/technical/api-oid-array.txt
+++ b/Documentation/technical/api-oid-array.txt
@@ -48,6 +48,11 @@ Functions
 	is not sorted, this function has the side effect of sorting
 	it.
 
+`oid_array_filter`::
+	Apply the callback function `want` to each entry in the array,
+	retaining only the entries for which the function returns true.
+	Preserve the order of the entries that are retained.
+
 Examples
 --------
 
diff --git a/sha1-array.c b/sha1-array.c
index b94e0ec0f5e..d922e94e3fc 100644
--- a/sha1-array.c
+++ b/sha1-array.c
@@ -77,3 +77,20 @@ int oid_array_for_each_unique(struct oid_array *array,
 	}
 	return 0;
 }
+
+void oid_array_filter(struct oid_array *array,
+		      for_each_oid_fn want,
+		      void *cb_data)
+{
+	unsigned nr = array->nr, src, dst;
+	struct object_id *oids = array->oid;
+
+	for (src = dst = 0; src < nr; src++) {
+		if (want(&oids[src], cb_data)) {
+			if (src != dst)
+				oidcpy(&oids[dst], &oids[src]);
+			dst++;
+		}
+	}
+	array->nr = dst;
+}
diff --git a/sha1-array.h b/sha1-array.h
index 232bf950172..55d016c4bf7 100644
--- a/sha1-array.h
+++ b/sha1-array.h
@@ -22,5 +22,8 @@ int oid_array_for_each(struct oid_array *array,
 int oid_array_for_each_unique(struct oid_array *array,
 			      for_each_oid_fn fn,
 			      void *data);
+void oid_array_filter(struct oid_array *array,
+		      for_each_oid_fn want,
+		      void *cbdata);
 
 #endif /* SHA1_ARRAY_H */
-- 
2.19.0.605.g01d371f741-goog
Previous: Stefan BellerNext: Junio C Hamano
Message 2 of 14 in “fetch: make sure submodule oids are fetched”
  1. 0/9 fetch: make sure submodule oids are fetchedStefan Beller, Sep 25, 2018
  2. 1/9 sha1-array: provide oid_array_filterStefan Beller, Sep 25, 2018
  3. Junio C HamanoSep 26, 2018
  4. 2/9 submodule.c: fix indentationStefan Beller, Sep 25, 2018
  5. Junio C HamanoSep 26, 2018
  6. 3/9 submodule.c: sort changed_submodule_names before searching itStefan Beller, Sep 25, 2018
  7. Junio C HamanoSep 26, 2018
  8. 4/9 submodule: move global changed_submodule_names into fetch submodule structStefan Beller, Sep 25, 2018
  9. Junio C HamanoSep 26, 2018
  10. 5/9 submodule.c: do not copy around submodule listStefan Beller, Sep 25, 2018
  11. 6/9 repository: repo_submodule_init to take a submodule structStefan Beller, Sep 25, 2018
  12. 7/9 submodule: fetch in submodules git directory instead of in worktreeStefan Beller, Sep 25, 2018
  13. 8/9 fetch: retry fetching submodules if needed objects were not fetchedStefan Beller, Sep 25, 2018
  14. 9/9 builtin/fetch: check for submodule updates for non branch fetchesStefan Beller, Sep 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.