Re: [PATCH] Revert "test-lib: whitelist GIT_TR2_* in the environment"

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 12, 2019, 17:49 UTC
Message-ID: <xmqq1rzyk81p.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190612142941.22056-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 7 quoted lines

> This reverts my commit c1ee5796dc ("test-lib: whitelist GIT_TR2_* in
> the environment", 2019-03-30), which is now redundant.
>
> Since e4b75d6a1d ("trace2: rename environment variables to
> GIT_TRACE2*", 2019-05-19) the GIT_TRACE2* variables match the existing
> GIT_TRACE* pattern added in 95a1d12e9b ("tests: scrub environment of
> GIT_* variables", 2011-03-15), so we no longer need to list TR2 here.

Yeah, makes sense.  Thanks.

Show 18 quoted lines

>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/test-lib.sh | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 599fd70e14..57f7c30377 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -386,7 +386,6 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
>  	my @env = keys %ENV;
>  	my $ok = join("|", qw(
>  		TRACE
> -		TR2_
>  		DEBUG
>  		TEST
>  		.*_TEST