Re: [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2*
On 5/28/2019 12:46 PM, Derrick Stolee wrote:
Show 21 quoted lines
> On 5/28/2019 12:25 PM, Junio C Hamano wrote:
>> SZEDER Gábor <szeder.dev@gmail.com> writes:
>>
>>> For an environment variable that is supposed to be set by users, the
>>> GIT_TR2* env vars are just too unclear, inconsistent, and ugly.
>>
>> FWIW, I personally am in favor of this change and would prefer to see
>> this done before the use of the names with unguessable abbreviation
>> gets ingrained too deeply.
>>
>> I do not see any objections around these two patches after waiting
>> for a week or so, but I do not see any Yay!s, either, so ...
>
> Talking with Jeff offline, we have no objections to the new names.
>
> We'll need to do some follow-up work on our side as we update our
> version of Git, but that's not an issue.
>
> Thanks,
> -Stolee
>
Just to close the loop. Yes, I'm OK with changing the names.
Jeff