git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] trace2: rename environment variables to GIT_TRACE2*

From
Derrick Stolee <stolee@gmail.com>
Date
May 28, 2019, 16:46 UTC
Message-ID
<f03e2ba6-36d8-d82b-3349-61341365b94e@gmail.com>
In-Reply-To
<xmqq36ky5ywr.fsf@gitster-ct.c.googlers.com>
On 5/28/2019 12:25 PM, Junio C Hamano wrote:
Show 11 quoted lines
> SZEDER Gábor <szeder.dev@gmail.com> writes:
> 
>> For an environment variable that is supposed to be set by users, the
>> GIT_TR2* env vars are just too unclear, inconsistent, and ugly.
> 
> FWIW, I personally am in favor of this change and would prefer to see
> this done before the use of the names with unguessable abbreviation
> gets ingrained too deeply.  
> 
> I do not see any objections around these two patches after waiting
> for a week or so, but I do not see any Yay!s, either, so ...
Talking with Jeff offline, we have no objections to the new names.

We'll need to do some follow-up work on our side as we update our version of Git, but that's not an issue.

Thanks, -Stolee

Previous: Junio C HamanoNext: Jeff Hostetler
Message 7 of 13 in “trace2: Add variable description to git.txt”
  1. 0/1 trace2: Add variable description to git.txtDerrick Stolee via GitGitGadget, May 10, 2019
  2. 1/1 trace2: Add variable description to git.txtDerrick Stolee via GitGitGadget, May 10, 2019
  3. SZEDER GáborMay 10, 2019
  4. 1/2 trace2: rename environment variables to GIT_TRACE2*SZEDER Gábor, May 19, 2019
  5. 2/2 trace2: document the supported values of GIT_TRACE2* env variablesSZEDER Gábor, May 19, 2019
  6. Junio C HamanoMay 28, 2019
  7. Derrick StoleeMay 28, 2019
  8. Jeff HostetlerMay 29, 2019
  9. Ævar Arnfjörð BjarmasonMay 28, 2019
  10. Jeff HostetlerMay 29, 2019
  11. Junio C HamanoMay 29, 2019
  12. Revert "test-lib: whitelist GIT_TR2_* in the environment"Ævar Arnfjörð Bjarmason, Jun 12, 2019
  13. Junio C HamanoJun 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.