Re: [PATCH v3 3/3] Ensured t5319 follows arith expansion guideline

From: Junio C Hamano <gitster@pobox.com>
Date: May 9, 2020, 16:55 UTC
Message-ID: <xmqq1rntvyhu.fsf@gitster.c.googlers.com>
In-Reply-To: <efeb3d7d1321e53e05079f296a5db5ab87f5fab2.1589034270.git.gitgitgadget@gmail.com>

"Son Luong Ngoc via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> From: Son Luong Ngoc <sluongng@gmail.com>
>
> As the old versions of dash is deprecated, dollar-sign inside
> artihmetic expansion is no longer needed.
> This ensures t5319 follows the coding guideline updated
> in 'jk/arith-expansion-coding-guidelines' 6d4bf5813cd2c1a3b93fd4f0b231733f82133cce.

That does not match my understanding of the guideline. By removing the "dollar required" rule and not adding a new "dollar forbidden" rule, we pretty much declared that "we do not care much either way" [*1*].

Even if we cared, "Once it _is_ in the tree, it's not really worth the patch noise to go and fix it up." rule from the guidelines applies here.

Thanks.

[Reference]

*1* https://lore.kernel.org/git/20200505210741.GB645290@coredump.intra.peff.net/