Re: [PATCH v2 2/2] multi-pack-index: respect repack.packKeptObjects=false

From: Derrick Stolee <stolee@gmail.com>
Date: May 6, 2020, 16:36 UTC
Message-ID: <a9ceac1c-8609-74b3-f40a-6d9e68574cd8@gmail.com>
In-Reply-To: <CAPig+cSBBVjBs6ypcpk=s+j2Vu4OXbhUnrJPq8tyoCDr+hX4rw@mail.gmail.com>

On 5/6/2020 12:18 PM, Eric Sunshine wrote:

Show 15 quoted lines

> On Wed, May 6, 2020 at 5:44 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh
>> @@ -538,6 +538,32 @@ test_expect_success 'repack with minimum size does not alter existing packs' '
>> +test_expect_success 'repack respects repack.packKeptObjects=false' '
>> +       test_when_finished rm -f dup/.git/objects/pack/*keep &&
>> +       (
>> +               [...]
>> +               THIRD_SMALLEST_SIZE=$(test-tool path-utils file-size .git/objects/pack/*pack | sort -n | head -n 3 | tail -n 1) &&
>> +               BATCH_SIZE=$(($THIRD_SMALLEST_SIZE + 1)) &&
> 
> Taking jk/arith-expansion-coding-guidelines[1] into consideration,
> perhaps write this as:
> 
>     BATCH_SIZE=$((THIRD_SMALLEST_SIZE + 1)) &&

Thanks for pointing this out. This line is repeated in the test after this one. That should be fixed, too.

Thanks, -Stolee