Re: [PATCH v2 2/2] multi-pack-index: respect repack.packKeptObjects=false
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- May 6, 2020, 16:18 UTC
- Message-ID
- <CAPig+cSBBVjBs6ypcpk=s+j2Vu4OXbhUnrJPq8tyoCDr+hX4rw@mail.gmail.com>
- In-Reply-To
- <3d7b334f5c6a89f438bba34cf91259cb67aebcd0.1588758194.git.gitgitgadget@gmail.com>
On Wed, May 6, 2020 at 5:44 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 8 quoted lines
> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh > @@ -538,6 +538,32 @@ test_expect_success 'repack with minimum size does not alter existing packs' ' > +test_expect_success 'repack respects repack.packKeptObjects=false' ' > + test_when_finished rm -f dup/.git/objects/pack/*keep && > + ( > + [...] > + THIRD_SMALLEST_SIZE=$(test-tool path-utils file-size .git/objects/pack/*pack | sort -n | head -n 3 | tail -n 1) && > + BATCH_SIZE=$(($THIRD_SMALLEST_SIZE + 1)) &&
Taking jk/arith-expansion-coding-guidelines[1] into consideration, perhaps write this as:
BATCH_SIZE=$((THIRD_SMALLEST_SIZE + 1)) &&
[1]: https://lore.kernel.org/git/20200504160709.GB12842@coredump.intra.peff.net/