Re: [PATCH] cmake: fix build of `t-oidtree`

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 13, 2024, 01:14 UTC
Message-ID: <xmqq1q3yjdp3.fsf@gitster.g>
In-Reply-To: <D2NXQ2WZFF24.1GVN7WUJ5PCHZ@gmail.com>

"Ghanshyam Thakkar" <shyamthakkar001@gmail.com> writes:

Show 5 quoted lines

> Changes look correct to me. I was not aware of the existance of
> CMakeLists in the tree cause there was no mention of CMake support
> in the docs about building git from source, but it was my mistake
> for grepping for 'test-lib' in just the Makefile instead of project
> wide. Apologies for the negligance and thanks for the patch.

No need to apologize. Nobody caught during the review, so it is not even your fault ;-)

And the CMakeLists is not even meant to work with anything but for Windows, IIRC (even though it might work by accident).