Re: [PATCH] cmake: fix build of `t-oidtree`

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 24, 2024, 10:19 UTC
Message-ID: <c109d620-0258-cc1a-e847-6c6c841a2232@gmx.de>
In-Reply-To: <D2NXQ2WZFF24.1GVN7WUJ5PCHZ@gmail.com>

Hi Ghanshyam,

On Sat, 13 Jul 2024, Ghanshyam Thakkar wrote:

Show 26 quoted lines

> Junio C Hamano <gitster@pobox.com> wrote:
> > "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> > writes:
> >
> > > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> > >
> > > When the `oidtree` test helper was turned into a unit test, a new
> > > `lib-oid` source file was added as dependency. This was only done in the
> > > Makefile so far, but also needs to be done in the CMake definition.
> > >
> > > This is a companion of ed548408723d (t/: migrate helper/test-oidtree.c
> > > to unit-tests/t-oidtree.c, 2024-06-08).
> > >
> > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > > ---
> > >     cmake: fix build of t-oidtree
> > >
> > >     This is based on the gt/unit-test-oidtree branch.
> > >
> > >     /cc "Ghanshyam Thakkar" shyamthakkar001@gmail.com
> >
> > The base topic has been merged last month during this cycle, so the
> > fix must be merged down to the 'master' before the release. Will
> > queue.
>
> Changes look correct to me.

Thank you for confirming.

For what it's worth, it was this confirmation by the domain expert (i.e. you) that I was looking for when I Cc:ed you, not to spread blame.

The CMakeLists.txt file exists primarily to support building Git in Visual Studio, and I removed that part from CI builds specifically so that contributors on the Git mailing list need not worry about that support.

Ciao, Johannes