git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cmake: fix build of `t-oidtree`

From
Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date
Jul 12, 2024, 23:04 UTC
Message-ID
<D2NXQ2WZFF24.1GVN7WUJ5PCHZ@gmail.com>
In-Reply-To
<xmqqa5iml28j.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> wrote:
Show 23 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > When the `oidtree` test helper was turned into a unit test, a new
> > `lib-oid` source file was added as dependency. This was only done in the
> > Makefile so far, but also needs to be done in the CMake definition.
> >
> > This is a companion of ed548408723d (t/: migrate helper/test-oidtree.c
> > to unit-tests/t-oidtree.c, 2024-06-08).
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >     cmake: fix build of t-oidtree
> >     
> >     This is based on the gt/unit-test-oidtree branch.
> >     
> >     /cc "Ghanshyam Thakkar" shyamthakkar001@gmail.com
>
> The base topic has been merged last month during this cycle, so the
> fix must be merged down to the 'master' before the release. Will
> queue.

Changes look correct to me. I was not aware of the existance of CMakeLists in the tree cause there was no mention of CMake support in the docs about building git from source, but it was my mistake for grepping for 'test-lib' in just the Makefile instead of project wide. Apologies for the negligance and thanks for the patch.

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 6 in “cmake: fix build of `t-oidtree`”
  1. cmake: fix build of `t-oidtree`Johannes Schindelin via GitGitGadget, Jul 12, 2024
  2. Johannes SchindelinJul 12, 2024
  3. Junio C HamanoJul 12, 2024
  4. Ghanshyam ThakkarJul 12, 2024
  5. Junio C HamanoJul 13, 2024
  6. Johannes SchindelinJul 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.