Re: [PATCH] branch: say "Reset to" in reflog entries for 'git branch -f' operations

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Apr 9, 2010, 12:18 UTC
Message-ID: <w2nbe6fef0d1004090518hee66e33esd93e767580837b55@mail.gmail.com>
In-Reply-To: <4BBF159A.1000206@drmicha.warpmail.net>

Hi,

On Fri, Apr 9, 2010 at 7:55 PM, Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 6 quoted lines

> I know the patch is not large, but one really has to read it after
> wondering: Huh? What is branch -f doing now before the patch? To me it
> sounded as if it didn't write to the reflog at all. So, how about
>
> elsewhere, it would make sense to say "Reset to" here as well rather
> than "Rest from".

Sounds good.

> But I also have a functional question: Is "start_from" really the ref
> *to* which the branch is reset? I hope reset does it right.

(I think you mean "start_name" instead of "start_from".)

Well, "start_name" determines where the branch/ref points to. I don't think any branch can "start", except that it can diverge.

But that's outside the scope of this patch.

-- 
Cheers,
Ray Chuan