Re: [RFC/PATCH 2/4] textconv: make diff_options accessible from blame

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 4, 2010, 07:59 UTC
Message-ID: <vpqy6evut1o.fsf@bauges.imag.fr>
In-Reply-To: <7vvd9z5owr.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Axel Bonnet <axel.bonnet@ensimag.imag.fr> writes:
>
>> Diff_options specify whether conversion is activated or not. Blame needs
>> to access these options in order to concert files with external drivers
>>
>> Signed-off-by: Diane Gasselin <diane.gasselin@ensimag.imag.fr>
>> Signed-off-by: ClÃ©ment Poulain <clement.poulain@ensimag.imag.fr>
>> Signed-off-by: Axel Bonnet <axel.bonnet@ensimag.imag.fr>
>
> The name of Clément is spelled correctly on the mail header while S-o-b
> line is corrupt.

Actually, it's valid UTF-8, but there's no header specifying the encoding in the email, therefore, the reader's default applies. My mailer displays it correctly, but yours doesn't.

> Perhaps you have recorded your commits in UTF-8 but allowed your MUA
> to send in 8859-1?

The MUA seems to be git-send-email. According to the source (I didn't find it in the doc), git-send-email looks at the patch's headers to specify the encoding.

On my machine, the patch applies well, and if I re-export it using format-patch, I do get the headers:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If I send myself the patch with git-send-email, I also get the headers in the email (I tried from ensibm, which is the machine which sent the patch serie). So, it doesn't look like a bug in git, but rather a miss-use.

Axel, can you give us the exact command(s) you used to send the patch?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/