Re: [RFC/PATCH 2/4] textconv: make diff_options accessible from blame

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 4, 2010, 17:23 UTC
Message-ID: <vpq1vcmaf0f.fsf@bauges.imag.fr>
In-Reply-To: <57f94007bc6d4f34d1929a005110073f@ensimag.fr>

bonneta <bonneta@ensimag.fr> writes:

Show 5 quoted lines

> On Fri, 04 Jun 2010 09:59:47 +0200, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>>> Axel Bonnet <axel.bonnet@ensimag.imag.fr> writes:

Show 7 quoted lines

>>>> Signed-off-by: ClÃ©ment Poulain <clement.poulain@ensimag.imag.fr>
>>>
>>> The name of Clément is spelled correctly on the mail header while S-o-b
>>> line is corrupt.
>> 
>> Actually, it's valid UTF-8, but there's no header specifying the
>> encoding in the email,

[...]

Show 6 quoted lines

>> Axel, can you give us the exact command(s) you used to send the patch?
>
> I made the patch with "git send-email --cover --annotate", and then edited
> the messages with vim.
>
> I added the S-o-b lines by copy-pasting them

OK, I got it. You ran "git format-patch", and it didn't find any non-ascii characters, so it didn't add any encoding header. Then you added UTF-8, and the header still wasn't there.

You can use "git rebase -i" to edit the commit messages directly, and add the s-o-b there, then git format-patch will DRT.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/