Re: [PATCH] show git tag output in pager
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Oct 3, 2011, 12:57 UTC
- Message-ID
- <vpqwrcmw7ve.fsf@bauges.imag.fr>
- In-Reply-To
- <20110930104241.GB24507@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> On Thu, Sep 29, 2011 at 11:37:49AM +0200, Michal Vyskocil wrote: > >> On Tue, Sep 27, 2011 at 04:19:39PM +0200, Matthieu Moy wrote: >> > The commit message should explain why this is needed, and in particular >> > why you prefer this to setting pager.tag in your ~/.gitconfig. >> >> Opps! I read a documentation, but I did not realize this works for all >> commands and not only for them calling setup_pager(). Then sorry, no >> change is needed. > > I don't think you want to set pager.tag. It will invoke the pager for > all tag subcommands, including tag creation and deletion.
That's the kind of argument/discussion I was expecting in the commit message.
> I think instead, you want some way for commands to say "OK, I'm in a > subcommand that might or might not want a pager now".
Right.
I like the try_subcommand_pager idea. Ideally, there would also be a nice mechanism to set defaults for subcommands, so that "git tag <whatever>" does the right thing without configuration.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/