Re: [PATCH] show git tag output in pager

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Oct 7, 2011, 14:48 UTC
Message-ID: <vpqsjn4dfi4.fsf@bauges.imag.fr>
In-Reply-To: <20111007144438.GA30318@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> On Mon, Oct 03, 2011 at 02:57:09PM +0200, Matthieu Moy wrote:
>
>> I like the try_subcommand_pager idea. Ideally, there would also be a
>> nice mechanism to set defaults for subcommands, so that "git tag
>> <whatever>" does the right thing without configuration.
>
> That's easy enough. Something like the patch below?

It may have been better with a big centralized array of configurations like

	static struct cmd_struct commands[] = {
		{ "add", cmd_add, RUN_SETUP | NEED_WORK_TREE },
                ...

in git.c, but if we have only a few instances of this, your system is probably fine. I like it.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/