git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] show git tag output in pager

From
MVMichal Vyskocil <mvyskocil@suse.cz>
Date
Sep 29, 2011, 09:37 UTC
Message-ID
<20110929093749.GB27152@zelva.suse.cz>
In-Reply-To
<vpqehz2cbk4.fsf@bauges.imag.fr>
On Tue, Sep 27, 2011 at 04:19:39PM +0200, Matthieu Moy wrote:
> The commit message should explain why this is needed, and in particular
> why you prefer this to setting pager.tag in your ~/.gitconfig.

Opps! I read a documentation, but I did not realize this works for all commands and not only for them calling setup_pager(). Then sorry, no change is needed.

Show 14 quoted lines
> 
> Michal Vyskocil <mvyskocil@suse.cz> writes:
> 
> > --- a/builtin/tag.c
> > +++ b/builtin/tag.c
> > @@ -147,6 +147,8 @@ static int list_tags(const char **patterns, int lines,
> >  			struct commit_list *with_commit)
> >  {
> >  	struct tag_filter filter;
> > +        
> > +        setup_pager();
> 
> Git indents with tabs, not spaces, and does not leave trailing
> whitespaces.

OK, thanks for the feedbac. I will try to be more carefull in the future.

Regards Michal Vyskocil

> 
> -- 
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
Previous: Matthieu MoyNext: Jeff King
Message 3 of 8 in “show git tag output in pager”
  1. show git tag output in pagerMichal Vyskocil, Sep 27, 2011
  2. Matthieu MoySep 27, 2011
  3. Michal VyskocilSep 29, 2011
  4. Jeff KingSep 30, 2011
  5. Matthieu MoyOct 3, 2011
  6. Jeff KingOct 7, 2011
  7. Matthieu MoyOct 7, 2011
  8. Jeff KingOct 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.