Re: [PATCH] push: start warning upcoming default change for push.default

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 20, 2012, 19:45 UTC
Message-ID: <vpqwr317oo2.fsf@bauges.imag.fr>
In-Reply-To: <7va9zxvkyp.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

>> 3) Set push.default to 'current', in which case they have the same
>>    behavior as 'simple', except for the safety feature of 'simple'
>>    (refuse to push when the name doesn't match the upstream). They can't
>>    expect anything better anyway since they are sometimes using a
>>    machine which doesn't support 'simple' anyway.
>
> And they will be frozen to 'current' even after their sysadmins
> update the version of git that support 'simple'.

And so what? They will miss the safety feature of 'simple', but that's not really a big deal.

'simple' was not really designed to be _better_ than current or upstream, but to be more adapted as a default value, because 1) it's safer, so nice for beginners and 2) follows the least surprise principle, as it does nothing in cases where there would be an ambiguity. But once you're not really a beginner, the added value of 'simple' is really small compared to 'current' or 'upstream'.

> Telling somebody who would blindly follow what was suggested to use
> 'current' is what bothers me.

But what alternative do we have?

You suggest that I remove the mention of 'current', but then what should users do? Removing it sounds like replacing it with "if you sometimes use older versions of Git, you're doomed, sorry" to me.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/