Re: [PATCH] push: start warning upcoming default change for push.default

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 21, 2012, 15:50 UTC
Message-ID: <vpqd34su0io.fsf@bauges.imag.fr>
In-Reply-To: <7v62alvk2e.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Perhaps we should say more to help people decide which one to choose
> in this message.

[...]

Show 6 quoted lines

>     You can squelch this message by picking your preferred default now,
>     e.g. running one of these:
>
>             git config push.default matching
>             git config push.default simple
>             git config push.default current

I don't see any added value. Seeing this, it's less clear to the user, and he may chose 'simple', and then complain that it breaks his older Git. Really, if 'simple' isn't an option for someone, why should we make this someone think before chosing between 'current' an 'simple'?

Also, my version purposely made 'simple' more visible than 'current' (cut-and-paste ready alone on its line Vs within parenthesis), because this is the one we want to advertise. Putting the 3 options at the same level is a regression to me.

We can rephrase the advice to make it clearer that 'simple' != 'current', like

  (the 'simple' mode was introduced in Git 1.7.11. Use the similar mode
  'current' instead if you sometimes use older versions of Git)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/