Re: [PATCH] push: start warning upcoming default change for push.default

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 21, 2012, 17:46 UTC
Message-ID: <7v62aksgkv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vk3z0shri.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 18 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Re-read the part you omitted with [...].  Doesn't it say something
>>> about "only available"?
>>
>> It does, but it seems you're trying hard to avoid telling the user "you
>> should use 'current'", where 'current' is the only reasonable option for
>> this user. I still don't understand what problem you're trying to solve.
>
> I am avoiding to say "you should use simple/current".  Choice
> between matching and simple/current is for the user to make (mostly
> dictated by the project's workflow) and we cannot make a suggestion
> better than what user knows.
>
> Choice between simple and current is mechanically derivable. If the
> user also uses older version of git, simple is not an option.

To put it another way, I am questioning your "where 'current is the only reasonable option for this user". If it were truly the case, why would we be issuing a warning message? Wouldn't we be instead silently doing what 'simple' or 'current' would do?

The reason why we have this message is because either "push the current one and not others" or "push all relevant ones, regardless of the current" are reasonable choices depending on the user, and because we had to choose one for the default, we previously chose the latter but we are changing our mind and will default to the other one, no?