Re: [PATCH_v1] add 'git credential' plumbing command

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 10, 2012, 13:18 UTC
Message-ID: <vpqvcizmhj5.fsf@bauges.imag.fr>
In-Reply-To: <1339267502-13803-1-git-send-email-Javier.Roucher-Iglesias@ensimag.imag.fr>

Javier.Roucher-Iglesias@ensimag.imag.fr writes:

> +static const char usage_msg[] =
> +"credential <fill|approve|reject>";

[...]

> +	for (i = 2; i < argc; i++)
> +		string_list_append(&c.helpers, argv[i]);

This helpers argument is still there, and is now totally undocumented. I shouldn't have to repeat that so many times.

Show 7 quoted lines

> --- a/git.c
> +++ b/git.c
> @@ -353,6 +353,7 @@ static void handle_internal_command(int argc, const char **argv)
>  		{ "commit-tree", cmd_commit_tree, RUN_SETUP },
>  		{ "config", cmd_config, RUN_SETUP_GENTLY },
>  		{ "count-objects", cmd_count_objects, RUN_SETUP },
> +		{ "credential", cmd_count_objects, RUN_SETUP },

Your "git credential" runs cmd_count_objects. A little bit of testing should have found that (my remarks about lack of testing still apply).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/