Re: [PATCH_v1] add 'git credential' plumbing command
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 11, 2012, 15:35 UTC
- Message-ID
- <7vhauh97zn.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120610210224.GA3112@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 16 quoted lines
> Jonathan Nieder wrote:
>> Matthieu Moy wrote:
>>> Junio C Hamano <gitster@pobox.com> writes:
>
>>>> Does "git credential" need to have a git repository (i.e. run in a
>>>> git repository or in a working tree that is controlled by one)?
>>>
>>> It shouldn't (hence, should use RUN_SETUP_GENTLY).
>>
>> Rather, that means it should use 0:
>>
>> { "credential", cmd_credential },
>
> ... and it turns out I'm talking nonsense. RUN_SETUP_GENTLY would
> be a sensible choice indeed, to allow the command to discover the
> current repository and read .git/config from there indeed.Yeah, I think "it is OK to be called outside a repository, but if inside we read and honor the configuration" is a sensible behaviour for this command.