Re: [PATCH_v1] add 'git credential' plumbing command

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 10, 2012, 13:16 UTC
Message-ID: <vpq1ulnnw81.fsf@bauges.imag.fr>
In-Reply-To: <7vzk8baca0.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

>> diff --git a/git.c b/git.c
>> index d232de9..7cbd7d8 100644
>> --- a/git.c
>> +++ b/git.c
>> @@ -353,6 +353,7 @@ static void handle_internal_command(int argc, const char **argv)
>>  		{ "commit-tree", cmd_commit_tree, RUN_SETUP },
>>  		{ "config", cmd_config, RUN_SETUP_GENTLY },
>>  		{ "count-objects", cmd_count_objects, RUN_SETUP },
>> +		{ "credential", cmd_count_objects, RUN_SETUP },
>
> Does "git credential" need to have a git repository (i.e. run in a
> git repository or in a working tree that is controlled by one)?

It shouldn't (hence, should use RUN_SETUP_GENTLY).

> A scripted Porcelain you would write using "git credential" may want
> to implement something like "git clone" or "git ls-remote" where you
> do not have to be in an existing repository.

("git clone" might not be the best example, as the authentication is usually done in the "git fetch" part of "git clone", but never mind)

Actually, "git credential" has very little to do with Git, and could even be used in a git-unrelated script.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/