git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 5/6] config: add `git_die_config()` to the config-set API

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jul 28, 2014, 11:16 UTC
Message-ID
<vpqvbqhu41s.fsf@anie.imag.fr>
In-Reply-To
<53D62DBD.9@gmail.com>
Tanay Abhra <tanayabh@gmail.com> writes:
Show 17 quoted lines
> On 7/28/2014 4:25 PM, Ramsay Jones wrote:
>> On 28/07/14 11:33, Tanay Abhra wrote:
>>> +	if (!kv_info->linenr)
>>> +		die("unable to parse command-line config");
>>> +	else
>>> +		die("bad config file line %d in %s",kv_info->linenr, kv_info->filename);
>> 
>> How about including the 'key' string in the error message?
>> Similar comment applies to an earlier patch in this series.
>>
>
> git_config_get_string & pathname() are already raising a
> config_error_nonbool() with the error message,
> "Missing value for 'key'".
>
> For other cases, I was just following the previous error message,
> but it can be done for the new git_config().

It is good to follow the existing in this patch (better code, same behavior), but I agree with Ramsay that including key in the error message (for both branches of the if/then/else) in a further patch would be good, and should be straightforward enough.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Tanay AbhraNext: Matthieu Moy
Message 12 of 15 in “Rewrite `git_config()` using config-set API”
  1. 0/6 Rewrite `git_config()` using config-set APITanay Abhra, Jul 28, 2014
  2. 1/6 config.c: fix accuracy of line number in errorsTanay Abhra, Jul 28, 2014
  3. 2/6 add line number and file name info to `config_set`Tanay Abhra, Jul 28, 2014
  4. 3/6 rewrite git_config() to use the config-set APITanay Abhra, Jul 28, 2014
  5. 4/6 add a test for semantic errors in config filesTanay Abhra, Jul 28, 2014
  6. Matthieu MoyJul 28, 2014
  7. Tanay AbhraJul 28, 2014
  8. Matthieu MoyJul 28, 2014
  9. 5/6 config: add `git_die_config()` to the config-set APITanay Abhra, Jul 28, 2014
  10. Ramsay JonesJul 28, 2014
  11. Tanay AbhraJul 28, 2014
  12. Matthieu MoyJul 28, 2014
  13. Matthieu MoyJul 28, 2014
  14. 6/6 add tests for `git_config_get_string_const()`Tanay Abhra, Jul 28, 2014
  15. Matthieu MoyJul 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.