git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 4/6] add a test for semantic errors in config files

From
Tanay Abhra <tanayabh@gmail.com>
Date
Jul 28, 2014, 11:27 UTC
Message-ID
<53D63389.5090205@gmail.com>
In-Reply-To
<vpqmwbtu3rh.fsf@anie.imag.fr>
On 7/28/2014 4:52 PM, Matthieu Moy wrote:
Show 17 quoted lines
> Tanay Abhra <tanayabh@gmail.com> writes:
> 
>> +test_expect_success 'check line errors for malformed values' '
>> +	mv .git/config .git/config.old &&
>> +	test_when_finished "mv .git/config.old .git/config" &&
>> +	cat >.git/config <<-\EOF &&
>> +	[alias]
>> +		br
>> +	EOF
>> +	test_expect_code 128 git br 2>result &&
>> +	grep "fatal: bad config file line 2 in .git/config" result
>> +'
> 
> This is PATCH 4, and it tests a bug fixed in PATCH 1. It would have
> eased review to group both patches, either
> 
> PATCH 1: introduce test_expect_failure test to demonstrate the failure

Didn't Junio comment that he wouldn't recommend inserting a test_expect_failure for new tests and then flipping them after in the series.

> PATCH 2: fix the bug and change test_expect_failure to test_expect_success
> 
> Or putting both in the same patch.
>
Much better, thanks for the advice.
> I think the series is OK like this, my comment is just to be read as
> "next time, here's how to do better".
>
Previous: Matthieu MoyNext: Matthieu Moy
Message 7 of 15 in “Rewrite `git_config()` using config-set API”
  1. 0/6 Rewrite `git_config()` using config-set APITanay Abhra, Jul 28, 2014
  2. 1/6 config.c: fix accuracy of line number in errorsTanay Abhra, Jul 28, 2014
  3. 2/6 add line number and file name info to `config_set`Tanay Abhra, Jul 28, 2014
  4. 3/6 rewrite git_config() to use the config-set APITanay Abhra, Jul 28, 2014
  5. 4/6 add a test for semantic errors in config filesTanay Abhra, Jul 28, 2014
  6. Matthieu MoyJul 28, 2014
  7. Tanay AbhraJul 28, 2014
  8. Matthieu MoyJul 28, 2014
  9. 5/6 config: add `git_die_config()` to the config-set APITanay Abhra, Jul 28, 2014
  10. Ramsay JonesJul 28, 2014
  11. Tanay AbhraJul 28, 2014
  12. Matthieu MoyJul 28, 2014
  13. Matthieu MoyJul 28, 2014
  14. 6/6 add tests for `git_config_get_string_const()`Tanay Abhra, Jul 28, 2014
  15. Matthieu MoyJul 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.