[PATCH v3 0/6] Rewrite `git_config()` using config-set API
- From
Tanay Abhra <tanayabh@gmail.com>
- Date
- Jul 28, 2014, 10:33 UTC
- Message-ID
- <1406543635-19281-1-git-send-email-tanayabh@gmail.com>
[PATCH V3]:All the suggestions in [3] applied. Built on top of [1].
[PATCH V2]: All the suggestions in [2] incorporated. git_config() now follows correct parsing order. Reordered the patches. Removed xfuncname patch as it was unnecssary.
This series builds on the top of topic[1] in the mailing list with name "git config cache & special querying API utilizing the cache".
This series aims to do these three things,
* Use the config-set API to rewrite git_config().
* Solve any legacy bugs in the previous system while at it.
* To be feature complete compared to the previous git_config() implementation, which I think it is now. (added the line number and file name info just for completeness)
Also, I haven't yet checked the exact improvements but still as a teaser, git status now only rereads the configuration files twice instead of four times.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/254286 [2]: http://thread.gmane.org/gmane.comp.version-control.git/254101 [3]: http://thread.gmane.org/gmane.comp.version-control.git/254211
Tanay Abhra (6): config.c: fix accuracy of line number in errors add line number and file name info to `config_set` rewrite git_config() to use the config-set API add a test for semantic errors in config files config: add `git_die_config()` to the config-set API add tests for `git_config_get_string()`
Documentation/technical/api-config.txt | 5 ++ cache.h | 25 ++++++++ config.c | 114 +++++++++++++++++++++++++++++---- t/t1308-config-set.sh | 20 ++++++ test-config.c | 10 +++ 5 files changed, 161 insertions(+), 13 deletions(-)
-- 1.9.0.GIT