git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 8, 2015, 11:54 UTC
Message-ID
<vpqvbeybejy.fsf@anie.imag.fr>
In-Reply-To
<1179544255.257552.1433703835857.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Please, don't top-post on this list.
Louis-Alexandre Stuber <stuberl@ensimag.grenoble-inp.fr> writes:
Show 5 quoted lines
> Thank you for the feedback. We are trying to apply all of your suggestions, but we would prefer to rebase the history before doing some of them (like renaming variables).
>
> About the BISECT_OLDNEWMODE file: The current implementation changes almost nothing to revision.c. We thought it was better, even if it needs a new file. The code for bisect uses BISECT_TERMS because 3 states are
> possible: 'bad/good mode', 'old/new mode', or 'no bisection started'
> (if BISECT_TERMS doesn't exist).

I don't think it's the main reason. The point is to make the code generic: once the bisection has started and the terms are chosen, the possible states for a commit are not really bad/good or old/new, but 'first line in BISECT_TERMS/second line in BISECT_TERMS'.

Show 8 quoted lines
> But the other files (like revision.c) don't need all these
> informations, so we thought it would be good to check if a file exists
> instead of reusing BISECT_TERMS, which would require reading its
> content.
>
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> De: "Christian Couder" <christian.couder@gmail.com>
> ...
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Louis-Alexandre Stuber
Message 8 of 8 in “git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.”
  1. 1/2 git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.Louis Stuber, Jun 5, 2015
  2. 2/2 Fix git rev-list --bisect and git bisect visualize when the bisection is done in old/new mode.Louis Stuber, Jun 5, 2015
  3. Eric SunshineJun 5, 2015
  4. Eric SunshineJun 5, 2015
  5. Matthieu MoyJun 8, 2015
  6. Christian CouderJun 5, 2015
  7. Louis-Alexandre StuberJun 7, 2015
  8. Matthieu MoyJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.