From: Matthieu Moy Date: Mon, 08 Jun 2015 11:54:57 GMT Subject: Re: [PATCH 1/2] git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced. Message-ID: In-Reply-To: <1179544255.257552.1433703835857.JavaMail.zimbra@ensimag.grenoble-inp.fr> Please, don't top-post on this list. Louis-Alexandre Stuber writes: > Thank you for the feedback. We are trying to apply all of your suggestions, but we would prefer to rebase the history before doing some of them (like renaming variables). > > About the BISECT_OLDNEWMODE file: The current implementation changes almost nothing to revision.c. We thought it was better, even if it needs a new file. The code for bisect uses BISECT_TERMS because 3 states are > possible: 'bad/good mode', 'old/new mode', or 'no bisection started' > (if BISECT_TERMS doesn't exist). I don't think it's the main reason. The point is to make the code generic: once the bisection has started and the terms are chosen, the possible states for a commit are not really bad/good or old/new, but 'first line in BISECT_TERMS/second line in BISECT_TERMS'. > But the other files (like revision.c) don't need all these > informations, so we thought it would be good to check if a file exists > instead of reusing BISECT_TERMS, which would require reading its > content. > > ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > De: "Christian Couder" > ... -- Matthieu Moy http://www-verimag.imag.fr/~moy/