git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.

From
LSLouis-Alexandre Stuber <stuberl@ensimag.grenoble-inp.fr>
Date
Jun 7, 2015, 19:06 UTC
Message-ID
<59937429.257594.1433703975898.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To
<1179544255.257552.1433703835857.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Thank you for the feedback. We are trying to apply all of your suggestions, but we would prefer to rebase the history before doing some of them (like renaming variables). 
About the BISECT_OLDNEWMODE file: The current implementation changes almost nothing to revision.c. We thought it was better, even if it needs a new file. The code for bisect uses BISECT_TERMS because 3 states are possible: 'bad/good mode', 'old/new mode', or 'no bisection started' (if BISECT_TERMS doesn't exist). But the other files (like revision.c) don't need all these informations, so we thought it would be good to check if a file exists instead of reusing BISECT_TERMS, which would require reading its content.
Previous: Christian CouderNext: Matthieu Moy
Message 7 of 8 in “git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.”
  1. 1/2 git-bisect.sh : create a file if the bisection is in old/new mode, named "BISECT_OLDNEWMODE", so it can easily be seen outside the program without having to read BISECT_TERMS. This will have to be changed in further versions if new terms are introduced.Louis Stuber, Jun 5, 2015
  2. 2/2 Fix git rev-list --bisect and git bisect visualize when the bisection is done in old/new mode.Louis Stuber, Jun 5, 2015
  3. Eric SunshineJun 5, 2015
  4. Eric SunshineJun 5, 2015
  5. Matthieu MoyJun 8, 2015
  6. Christian CouderJun 5, 2015
  7. Louis-Alexandre StuberJun 7, 2015
  8. Matthieu MoyJun 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.