Re: [1.8.0] git-stash invocation changes
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Feb 2, 2011, 18:15 UTC
- Message-ID
- <vpqtygmwbee.fsf@bauges.imag.fr>
- In-Reply-To
- <AANLkTimu=drR+4v+B_aB+Y4jVqzaBghh1XYSZoACsBry@mail.gmail.com>
Shawn Pearce <spearce@spearce.org> writes:
Show 10 quoted lines
> On Wed, Feb 2, 2011 at 09:23, Thomas Rast <trast@student.ethz.ch> wrote: >> Proposal: >> >> 1. Change 'git stash <not-a-stash-command>' to give a usage message >> instead of using <not-a-stash-command> as the stash message. > > Oh please, yes, please do this. We should have done this long, long > ago. Its easy enough to train your fingers or fix your scripts to say > `git stash save list` rather than `git stash lsit` once stash errors > out and gives you a usage message once.
Err, hasn't this been fixed long ago already?
$ git stash not-a-stash-command
Usage: git stash list [<options>]
or: git stash show [<stash>]
or: git stash drop [-q|--quiet] [<stash>]
or: git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]
or: git stash branch <branchname> [<stash>]
or: git stash [save [--patch] [-k|--[no-]keep-index] [-q|--quiet] [<message>]]
or: git stash clear
$ git stash save --no-such-option
error: unknown option for 'stash save': --no-such-option
To provide a message, use git stash save -- '--no-such-option'
Usage: [...]Only this could be seen as a problem:
$ git stash save this-is-not-a-stash-name Saved working directory and index state On master: this-is-not-a-stash-name
in particular, it is wrt:
Thomas Rast <trast@student.ethz.ch> writes:
> 2. Change 'git stash -p <args>' to treat the <args> as filename > arguments similar to add -p. Possibly add a -m option that lets > you specify a message anyway, if desired.
I'm not a user of "stash with messages" myself, so I can't say how annoying the migration would be, but -m "message" sounds good to me.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/