git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-contacts questions

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Oct 29, 2013, 14:39 UTC
Message-ID
<vpqsivkywdx.fsf@anie.imag.fr>
In-Reply-To
<CAHGBnuNWtgH_aYxv0gX44AkGTRo6vsKdd4w1cViLGD9O9RLaNQ@mail.gmail.com>
Sebastian Schuberth <sschuberth@gmail.com> writes:
Show 26 quoted lines
> On Tue, Oct 29, 2013 at 11:35 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> On Tue, Oct 29, 2013 at 3:12 AM, Sebastian Schuberth
>> <sschuberth@gmail.com> wrote:
>>> On Tue, Oct 29, 2013 at 9:57 AM, Felipe Contreras
>>> <felipe.contreras@gmail.com> wrote:
>>>
>>>>> 1) Passing just "HEAD" as a committish like in "git contacts HEAD"
>>>>> does not output anything for me, but using the SHA1 for HEAD does
>>>>> neither. My HEAD commit does not add any files, but only modifies
>>>>> previously existing files, so I would have expected some output. In
>>>>> case it turns out to be correct to have no output in my case, could we
>>>>> probably say that in some message to the user?
>>>>
>>>> It should be HEAD^, or -1, like with 'git format-patch'.
>>>
>>> Oh, that's pretty much unexpected. Wouldn't it be much more natural if
>>> I had to specify the commit(s) that introduce(s) the changes that I
>>> want others to look at?
>>
>> Yeah, that's exactly what you are doing. How do you tell 'git log' to
>> show you certain changes?
>
> I'm not sure what you're trying to point me at. It's clear that from
> an implementation view you need to blame HEAD^ if you need to know
> which poeple should review your changes in HEAD.

I agree that the situation when providing only HEAD is really disappointing...

> But IMHO that is an implementation detail that should be hidden from
> the user.

... but it's not just an implementation detail: git-contacts takes a range of commits, so you can ask for people to Cc for a whole patch series for example.

If I understand correctly, "git contact $ONE_COMMIT" does "git contact $ONE_COMMIT..HEAD" implicitly, and this is weird when $ONE_COMMIT is HEAD.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Sebastian SchuberthNext: Sebastian Schuberth
Message 6 of 10 in “git-contacts questions”
  1. Sebastian SchuberthOct 29, 2013
  2. Felipe ContrerasOct 29, 2013
  3. Sebastian SchuberthOct 29, 2013
  4. Felipe ContrerasOct 29, 2013
  5. Sebastian SchuberthOct 29, 2013
  6. Matthieu MoyOct 29, 2013
  7. Sebastian SchuberthOct 29, 2013
  8. Felipe ContrerasOct 29, 2013
  9. Eric SunshineOct 29, 2013
  10. Sebastian SchuberthOct 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.