Re: git-contacts questions

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Oct 29, 2013, 09:12 UTC
Message-ID: <CAHGBnuP6nyTCGGNntvWVYAtxNX9xgt6=F3HheiEUcPU_9TP-1g@mail.gmail.com>
In-Reply-To: <CAMP44s1+npNnR8-exARL8kamQ81JwyLhhQnnkv6DvK8e3qOfHA@mail.gmail.com>

On Tue, Oct 29, 2013 at 9:57 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 8 quoted lines

>> 1) Passing just "HEAD" as a committish like in "git contacts HEAD"
>> does not output anything for me, but using the SHA1 for HEAD does
>> neither. My HEAD commit does not add any files, but only modifies
>> previously existing files, so I would have expected some output. In
>> case it turns out to be correct to have no output in my case, could we
>> probably say that in some message to the user?
>
> It should be HEAD^, or -1, like with 'git format-patch'.

Oh, that's pretty much unexpected. Wouldn't it be much more natural if I had to specify the commit(s) that introduce(s) the changes that I want others to look at?

Show 14 quoted lines

>> 2) For some commits I get error messages from "git blame" in function
>> get_blame because multiple -L options are specified:
>>
>> $ git contacts b0783baacd20be7007df40cf274985c4863d63fb
>> fatal: More than one '-L n,m' option given
>> fatal: More than one '-L n,m' option given
>> fatal: More than one '-L n,m' option given
>> fatal: More than one '-L n,m' option given
>>
>> From reading git-blame's man page it indeed seems to me as if only one
>> -L option is allowed, so is this something that needs to be fixed in
>> git-contacts?
>
> You are probably using a newer version of the script on an older version of Git.

Well, I'm running Git for Windows 1.8.4, and according to [1] git-blame was not changed after 1.8.4.

> You can also try git-related instead[1].
>
> [1] https://github.com/felipec/git-related

I just did very quickly (with Ruby 1.8.7) and I get:

$ git related b0783baacd20be7007df40cf274985c4863d63fb
C:/Program Files (x86)/Git/libexec/git-core/git-related:309:in
`popen': can't convert Array into String (TypeError)
        from C:/Program Files
(x86)/Git/libexec/git-core/git-related:309:in `from_rev_args'
        from C:/Program Files (x86)/Git/libexec/git-core/git-related:345

[1] http://git-scm.com/docs/git-blame.html

-- 
Sebastian Schuberth