Re: git-contacts questions

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Oct 29, 2013, 15:02 UTC
Message-ID: <CAHGBnuOT1ttzSuzCt4GDxJ7iap6VM1Sbyuve2FGR7pdf2z40bg@mail.gmail.com>
In-Reply-To: <vpqsivkywdx.fsf@anie.imag.fr>

On Tue, Oct 29, 2013 at 3:39 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 17 quoted lines

>> I'm not sure what you're trying to point me at. It's clear that from
>> an implementation view you need to blame HEAD^ if you need to know
>> which poeple should review your changes in HEAD.
>
> I agree that the situation when providing only HEAD is really
> disappointing...
>
>> But IMHO that is an implementation detail that should be hidden from
>> the user.
>
> ... but it's not just an implementation detail: git-contacts takes a
> range of commits, so you can ask for people to Cc for a whole patch
> series for example.
>
> If I understand correctly, "git contact $ONE_COMMIT" does
> "git contact $ONE_COMMIT..HEAD" implicitly, and this is weird when
> $ONE_COMMIT is HEAD.

It's not only weird if $ONE_COMMIT is HEAD, but for any single commit. At least I would expect "git contacts $ONE_COMMIT" to list the poeple interested in the single commit $ONE_COMMIT. Instead, what it seems to do is list the people who are interested in the commits *after* $ONE_COMMIT.

-- 
Sebastian Schuberth