Re: [PATCH 0/7] Rewrite `git_config()` using config-set API

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 24, 2014, 16:17 UTC
Message-ID: <vpqsilq7muy.fsf@anie.imag.fr>
In-Reply-To: <53D12D56.2080505@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

Show 15 quoted lines

> On 7/24/2014 9:09 PM, Matthieu Moy wrote:
>> Tanay Abhra <tanayabh@gmail.com> writes:
>> 
>>> I am attaching the v12 with two new functions git_configset_get_string() &
>>> git_configset_get_string_const().
>> 
>> Didn't you intend to change git_config_get_string to let it die in case
>> of error instead of returning an error code?
>>
>
> Yup, but it is the part of the new series not the old one.
> I sent this revised patch just for solving the constness
> debate.
> Also, I would need git_die_config() to print a proper
> error message which comes in the 7 part series not this one.

Ah, right, you don't have line numbers yet, so you can't die properly.

So, hopefully, this part can be considered done, and we can continue building on top.

As a side effect, I guess Junio will apply this on top of master so the string interning API will be available immediately at the tip of the branch.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/