Re: [PATCH 2/7] rewrite git_config() to use the config-set API
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jul 24, 2014, 06:43 UTC
- Message-ID
- <vpqfvhrqmsm.fsf@anie.imag.fr>
- In-Reply-To
- <xmqq7g33d9fe.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 8 quoted lines
>> +int git_config(config_fn_t fn, void *data)
>> +{
>> + git_config_check_init();
>> + return configset_iter(&the_config_set, fn, data);
>> +}
>
> Perhaps if you define this function at the right place in the file
> you do not have to add an forward decl of git_config_check_init()?OTOH, having git_config right next to git_config_raw and configset_iter is a good thing, and keeping git_config_raw where git_config used to be seems logical.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/