Re: [PATCH v2 0/7] t5520: tests for --[no-]autostash option

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Apr 4, 2016, 07:31 UTC
Message-ID: <vpqshz125jr.fsf@anie.imag.fr>
In-Reply-To: <1459619912-5445-1-git-send-email-mehul.jain2029@gmail.com>

Mehul Jain <mehul.jain2029@gmail.com> writes:

Show 7 quoted lines

> -test_rebase_autostash () {
> +test_pull_autostash () {
>  	git reset --hard before-rebase &&
>  	echo dirty >new_file &&
>  	git add new_file &&
> -	git pull --rebase --autostash . copy &&
> +	git pull $@ . copy &&

Not strictly needed here, but I'd write "$@" (with the double-quotes) which is the robust way to say "transmit all my arguments without whitespace interpretation".

I don't mind for this patch since there's no whitespace to interpret, but some people (sysadmins ;-) ) have the bad habit of writting $@, $* or "$*" in wrapper scripts and it breaks when you call them with spaces so it's better to take good habits IHMO.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/