Re: [PATCH v2 0/7] t5520: tests for --[no-]autostash option
- From
Mehul Jain <mehul.jain2029@gmail.com>
- Date
- Apr 4, 2016, 17:07 UTC
- Message-ID
- <CA+DCAeQU2eOA7gQ4Q=GTGWeNuAzor0aL4DUFnD+8vYErPc21DA@mail.gmail.com>
- In-Reply-To
- <xmqqmvp95mxl.fsf@gitster.mtv.corp.google.com>
On Mon, Apr 4, 2016 at 10:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Mehul Jain <mehul.jain2029@gmail.com> writes:
>>
>>> -test_rebase_autostash () {
>>> +test_pull_autostash () {
>>> git reset --hard before-rebase &&
>>> echo dirty >new_file &&
>>> git add new_file &&
>>> - git pull --rebase --autostash . copy &&
>>> + git pull $@ . copy &&
>>
>> Not strictly needed here, but I'd write "$@" (with the double-quotes)
>> which is the robust way to say "transmit all my arguments without
>> whitespace interpretation".
>
> Yes, these should be "$@" (with the double-quotes).I will do a re-roll then.
Thanks, Mehul