Re: [PATCH] Makefile: add uninstall target. Fixes elementary good cleaning manners.

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Nov 18, 2009, 13:28 UTC
Message-ID: <vpqr5rwdksg.fsf@bauges.imag.fr>
In-Reply-To: <1258547389.25909.101.camel@heerbeest>

Jan Nieuwenhuizen <janneke-list@xs4all.nl> writes:

> Sorry.  Let me retry that.  See below.

Please, read Documentation/SubmittingPatches

Show 9 quoted lines

>>From f260a4dcf0b42088eb1da74aee49f49ac4b0c55b Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Wed, 11 Nov 2009 14:19:00 +0100
> Subject: [PATCH] Makefile: add uninstall target.  Fixes elementary good cleaning manners.
>
>    * Modified     Makefile
>    * Modified     gitk-git/Makefile
>    * Modified     perl/Makefile
>    * Modified     templates/Makefile

Git knows better than you which files are modified by a commit, so it's counter-productive to rewrite by hand this list in the commit message. This place is the place to explain _why_ your change is good (to convince the maintainer to apply it in git.git in particular).

>  Makefile           |   18 +++++++++++++++++-
>  gitk-git/Makefile  |    2 ++
>  perl/Makefile      |    2 +-
>  templates/Makefile |    5 +++++

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/