Re: [PATCH] git-pull.sh: overhaul error handling when no candidates are found
- From
Jeff King <peff@peff.net>
- Date
- Nov 12, 2009, 15:28 UTC
- Message-ID
- <20091112152849.GA25352@coredump.intra.peff.net>
- In-Reply-To
- <20091112162558.6b1c4a43@perceptron>
On Thu, Nov 12, 2009 at 04:25:58PM +0100, Jan Krüger wrote:
Show 5 quoted lines
> > Personally, I would go the other way: give them something they can cut > > and paste on the command line, like: > > A matter of taste, I suppose. The user has to edit the lines anyway > since they contain placeholders.
Oh, true. I was thinking we filled them in with the right values, but of course we don't know what those values are (if we did, we wouldn't be bugging the user...). So ignore what I said.
Show 5 quoted lines
> > Isn't branch.*.rebase a boolean value? > > Argh! Of course it is. Note to self: don't write patches in a hurry. > Disregard everything I said. I thought I was seeing incorrect behavior > in what Jan (N.) reported...
If it makes you feel better, the reason I noticed your error so quickly is that I made the _exact_ same one while doing a patch in that area a month or two ago.
-Peff