Re: [PATCH] pull: clarify advice for the unconfigured error case

From: Jeff King <peff@peff.net>
Date: Dec 3, 2009, 01:43 UTC
Message-ID: <20091203014315.GA12061@coredump.intra.peff.net>
In-Reply-To: <20091203012535.GA16259@progeny.tock>

On Wed, Dec 02, 2009 at 07:26:14PM -0600, Jonathan Nieder wrote:

Show 10 quoted lines

> > and does the lack of follow-up mean everybody involved in the discussion
> > is happy with this version?
> 
> I’m not sure.  I know I like it. :-)
> 
> I was the only one with nitpicks about the wording (sorry).  Re
> whether to use configuration file syntax or a 'git config' command
> line snippet, it seemed like there was some consensus once it was
> clear that the user would have to modify the lines anyway to fill in
> the right values.  But others can speak up if this seems wrong.

Yeah, that was my main complaint, and I withdrew it after getting a clue. :) I gave the patch another quick look, and I think it is fine.

-Peff