Re: [PATCH] bash-completion: don't add quoted space for ZSH (fix regression)

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jan 17, 2012, 12:21 UTC
Message-ID: <vpqr4yy1pv6.fsf@bauges.imag.fr>
In-Reply-To: <7vsjjfuuwk.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> but is that the right thing to do if suffix came from "$4"?
>>>
>>> As far as I can see, "$4" is used to append "." in very limited cases, and
>>> nobody explicitly passes SP as "$4" when calling this, so it may be easier
>>> to read if you moved this before that "if we have 3 or more args, use the
>>> fourth one as the suffix" block, i.e. something like this?
>>
>> Why not, but in case someone explicitely passes " " as $4 in the future,
>> it's likely to be better to strip it for the same reason we strip it here.
>
> I doubt that would be sufficent or appropriate. If some caller _WANTS_ to
> add a SP, shouldn't we be devising a way to tell zsh to add it without
> quoting,

Yes, this is the point. But up to now, nobody found such a way so we're just trying to work around it in the less painfull way for the user.

If someone _wants_ to add a SP, then he still can't do it portably with your patch, because the space will be quoted for bash users, and not for ZSH users, so one of them will be unhappy.

> So does that mean we would be forcing zsh users to add SP themselves?

Yes, but we already do so. From my commit message:

  The absence of trailing space for ZSH is a long-standing issue, that
  this patch is not fixing.

;-).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/