Re: [PATCH] bash-completion: don't add quoted space for ZSH (fix regression)
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Jan 17, 2012, 20:03 UTC
- Message-ID
- <CAMP44s0T15idhwb6Eae5vdMxf25KK9MhY57mBf+BFN=OSC6Lhg@mail.gmail.com>
- In-Reply-To
- <CAMP44s2nYMmfC36+pGaYfOZUQy3fLMYDuaSriPYjHBeApmsRVg@mail.gmail.com>
On Tue, Jan 17, 2012 at 9:18 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:
Show 11 quoted lines
> On Sat, Jan 14, 2012 at 8:55 PM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote: >> Commit a31e626 (completion: optimize refs completion) introduced a >> regression for ZSH users: ref names were completed with a quoted trailing >> space (i.e. "git checkout ma" completes to "git checkout master\ "). The >> space is convenient for bash users since we use "-o nospace", but a >> quoted space is worse than nothing. The absence of trailing space for ZSH >> is a long-standing issue, that this patch is not fixing. We just fix the >> regression by not appending a space when the shell is ZSH. > > I have this issue with the script from v1.7.8.3, and I think it > started with a zsh update.
Yeah, works fine with zsh 4.3.11, not 4.3.14 or 15.
-- Felipe Contreras